0x41gawor / lupus

Lupus - design and run loops in Kubernetes. Part of my Master Thesis
0 stars 0 forks source link

Nest or not to nest #8

Closed 0x41gawor closed 5 days ago

0x41gawor commented 2 weeks ago

image

0x41gawor commented 2 weeks ago

In this case it was unfortunate and bad design of Opa. But should give the user possibility to do such action. Here we have two options.

  1. Introduce new Action called "Nest". It would just create a new outputkey that contains inputkey it itself.
  2. Introduce new option in SendAction where you can decide if to send content of a filed or whole field.

At first glance, 1 option appears to be 10x better. It gives more elasticity, atomicity and leaves Send Action as simple as it is. The only drawback is that functionally it is a subset of concat. Actually it is a concat where inputKeys array is one element. Maybe rename concat to nest and everything is good?

0x41gawor commented 5 days ago

Yeah, definetely the best solution is just to rename concat action type to nest.