search

0xB10C / peer-observer

Tool to monitor for P2P anomalies and attacks using Bitcoin Core honeynodes
https://public.peer.observer
MIT License
12 stars 2 forks source link

clean: rename wrapper to eventer & wrap to event #24

Closed i-am-yuvi closed 4 months ago

i-am-yuvi commented 4 months ago

Describe your changes

The wrapper field is renamed to eventer in the same way wrap is changed to event.

Issue ticket number and link

18

Checklist before requesting a review

Screenshots

Compiling Program

Compiling Code

Running extractor

running extractor

Running Logger

running logger
0xB10C commented 4 months ago

Also make sure to run cargo fmt before commiting. Otherwise the CI will complain :)

https://github.com/0xB10C/peer-observer/actions/runs/9961953175/job/27547091674?pr=24

0xB10C commented 4 months ago

Compiling Program

Compiling Code

No need to include such screenshots. It's the task of a reviewer (with the help of CI) to verify the changes.

0xB10C commented 4 months ago

Oh and we should run https://github.com/0xB10C/peer-observer/blob/master/protobuf/gen-python.sh to regenerate the Python protobuf definitions. You can add these changes in a separate commit.

i-am-yuvi commented 4 months ago

Okay I shall make the changes!!

0xB10C commented 4 months ago

Looks good! Can you change this up into two commits similar to this:

Having the second commit split off allows me to run gen-python.sh myself and see if we get any differences.

Once that's done, I think this is ready for merge.

i-am-yuvi commented 4 months ago

Surely!!!