0xB10C / peer-observer

Tool to monitor for P2P anomalies and attacks using Bitcoin Core honeynodes
https://public.peer.observer
MIT License
12 stars 2 forks source link

Rename wrapper #25

Closed i-am-yuvi closed 4 months ago

i-am-yuvi commented 4 months ago

Describe your changes

The wrapper field is renamed to eventer in the same way wrap is changed to event.

Issue ticket number and link

18

Checklist before requesting a review

0xB10C commented 4 months ago

feel free to squash the cargo fmt changes with the rename commit :)

i-am-yuvi commented 4 months ago

feel free to squash the cargo fmt changes with the rename commit :)

Done!!!

i-am-yuvi commented 4 months ago

Can you tell me what protoc --version outputs for you? It's libprotoc 24.4 for me and the diff of the python protobuf files is a lot smaller when running gen-python.sh. Wondering if we are using the same tool/version?

Okay my bad the version of protoc in my system is 3.1 I had downloaded from apt, I have downloaded the new one from github release. Will update the changes and squash it with the second commit, I think this won't be an issue?

i-am-yuvi commented 4 months ago

I'm not entirely sure which protoc tool you are using. Can you point me to the GitHub release you've downloaded? It seems we are using two different tools.

When we're not using the same tool, the next time I'm going to update the python-types with my protoc tool this will change back. Ideally, I want to avoid that.

I am using libprotoc 25.1 on my machine. You can find here :)

i-am-yuvi commented 4 months ago

@0xB10C I am getting the size of python file very less when running with libprotoc v24.4 as compared to other versions of libprotoc. Shall I push that??

0xB10C commented 4 months ago

@0xB10C I am getting the size of python file very less when running with libprotoc v24.4 as compared to other versions of libprotoc. Shall I push that??

Yes, please try that. Using v25 or v26 still produces files matching what's on master for me.

i-am-yuvi commented 4 months ago

I guess it looks fine now!!

0xB10C commented 4 months ago

Awesome, yes! Thanks!

0xB10C commented 4 months ago

We'll probably need to update some of the python tools too - they aren't tested by CI yet. Not here, though :)