Closed i-am-yuvi closed 4 months ago
feel free to squash the cargo fmt
changes with the rename commit :)
feel free to squash the
cargo fmt
changes with the rename commit :)
Done!!!
Can you tell me what
protoc --version
outputs for you? It'slibprotoc 24.4
for me and the diff of the python protobuf files is a lot smaller when runninggen-python.sh
. Wondering if we are using the same tool/version?
Okay my bad the version of protoc in my system is 3.1 I had downloaded from apt, I have downloaded the new one from github release. Will update the changes and squash it with the second commit, I think this won't be an issue?
I'm not entirely sure which
protoc
tool you are using. Can you point me to the GitHub release you've downloaded? It seems we are using two different tools.When we're not using the same tool, the next time I'm going to update the python-types with my
protoc
tool this will change back. Ideally, I want to avoid that.
I am using libprotoc 25.1
on my machine. You can find here :)
@0xB10C I am getting the size of python file very less when running with libprotoc v24.4
as compared to other versions of libprotoc
. Shall I push that??
@0xB10C I am getting the size of python file very less when running with
libprotoc v24.4
as compared to other versions oflibprotoc
. Shall I push that??
Yes, please try that. Using v25 or v26 still produces files matching what's on master for me.
I guess it looks fine now!!
Awesome, yes! Thanks!
We'll probably need to update some of the python tools too - they aren't tested by CI yet. Not here, though :)
Describe your changes
The
wrapper
field is renamed toeventer
in the same waywrap
is changed toevent
.Issue ticket number and link
18
Checklist before requesting a review