Open SuperQ opened 2 months ago
Attention: Patch coverage is 81.81818%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 93.85%. Comparing base (
fe84ab8
) to head (823c916
). Report is 147 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
lists/list_cache.go | 77.77% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm working on an improvement to the tests using the client_golang testutil.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
Not really stale, but I haven't had a chance to work on the coverage change.
@0xERR0R, how do you feel about the coverage change here?
@0xERR0R, how do you feel about the coverage change here?
It is always nice to cover more code, but it is not an ultimate goal to have 100% coverage :)
Part 2 (#1578)
Improve performance of metrics by moving them to the package that needs them. This reduces the overhead to a simple atomic increment for basic counters like cache hits/misses. This also uses
promauto
to avoid the second step of having to register metrics.