search

0xPolygonZero / zk_evm

Apache License 2.0
86 stars 38 forks source link

Consider property-based testing for `evm_arithmetization` crate #55

Open Nashtare opened 9 months ago

Nashtare commented 9 months ago

LA auditors suggested we use proptest in different places of the codebase, to strengthen overall testing. It's a meaningful suggestion, although it doesn't apply everywhere, so we would need to define where this makes sense and integrate it. Arithmetic tests for ArithmeticStark most likely would be a good place to start.

Nashtare commented 4 months ago

@temaniarpit27 I see you assigned yourself 4 days ago. Is this item currently being worked on?

temaniarpit27 commented 4 months ago

@Nashtare yes i will start working on this once I am back from ethcc next week I have discussed the same with @muursh and he asked me to do some reading upon zk internals and math part. Once getting the basics for this, I will start implementing test cases

temaniarpit27 commented 3 months ago

@Nashtare moving this to backlog for now. i will be working on some other task on prioirty after discussing with ben.