search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Throw BaseStepModalException to clean up steps modal. #278

Closed unjapones closed 5 years ago

unjapones commented 5 years ago

Closes #252.

To manually reproduce the bug:

  1. Use the app with Kovan to have some transaction time and open the Dev Tools.
  2. Go to My Wallet and select a token to toggle its lock.
  3. Open the toggle lock tocken by opening the dialog.
  4. After submitting the transaction on Metamask, immediately close the toggle lock dialog by clicking on the X.
  5. Wait some time and see an error/warning in the console due to a setState invokation on an unmounted component. Optionally you can open the toggle token lock dialog and see how it automatically closes.
unjapones commented 5 years ago

I'll wait for @fvictorio 's approval , since he implemented the base component for the steps.