Review modals design - Githubissues

0xProject / 0x-launch-kit-frontend

Apache License 2.0

112 stars 207 forks source link

Review modals design #300

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #274

I did not see any noticeable design error. I modify some descriptions of the modals so they were similar to the existing ones in the designs.

fvictorio commented 5 years ago

Some comments:

The text at the bottom is sometimes gray and sometimes black. Maybe this is by design, but it looks weird.
I think this has been mentioned before, but the progress bar "jumps" when there are no text. Maybe we can fix that using a   instead of a null there (or some more elegant solution).

mariano-aguero commented 5 years ago

The text at the bottom is sometimes gray and sometimes black. Maybe this is by design, but it looks weird.

Right now uses textLight, I think that unless someone suggest a modification it should be like that.

I think this has been mentioned before, but the progress bar "jumps" when there are no text. Maybe we can fix that using a   instead of a null there (or some more elegant solution).

Added a component Nbsp to fix this.

Regards