Use a convention in redux action types.

unjapones commented 5 years ago

Use {namespace}/{NOUN}_{verb} convention for redux action types.

Some action types related with an async fetch should add: _request, _success and failure suffixes accordingly.

Pay attention what parts of the sting are in lowercase/UPPERCASE.
Did not see the need to prefix with @@0x-launch-kit-frontend (too long, and probably dependencies/libs are already doing that).

Some action types do not involve a NOUN, for example; INITIALIZE_BLOCKCHAIN_DATA became blockchain/init.

Note that, as we continue to change/improve the interaction with the store, the names of the action types may not stick 100% to this convention. This is a starting point though.

Just in case, the actions log in redux dev tools like like this: redux_log

fvictorio commented 5 years ago

Approved because my request shouldn't block this PR, but I think it's small and important enough to do it here.

Agupane commented 5 years ago

I'd approved this pr, @unjapones once you decide to resolve or not the conversation with @fvictorio feel free to close the pr

0xProject / 0x-launch-kit-frontend

Use a convention in redux action types. #328