Closed mariano-aguero closed 5 years ago
You can try accessing to the URL http://localhost:3001/erc721/my-collectibles
Hi @mariano-aguero please check that the branch has conflicts, thanks!
This is what I think about the state shape:
First, let's not touch the relayer
and market
slices. While it bothers me that they are used only for the ERC20 part of the app (because the NFT part also uses the relayer and it's a market), I think we can live with that for now.
Second, I would make some changes to how the CollectibleState
is shaped. I think it should be something like:
CollectiblesState {
userCollectibles: {[tokenId: string]: Collectible}
}
See Normalizing State Shape for the reasoning behind this. I changed myCollectibles
to userCollectibles
to be more consistent with the naming we've been using so far.
The Collectible
interface seems OK enough for now, although it should have an id
field, and its price shouldn't be a string
.
Q: Should this pr consider a placeholder for this components?. I mean, no the functionality but the components placed
@Agupane
Q: Should this pr consider a placeholder for this components?. I mean, no the functionality but the components placed
In my opinion no: we initially want to have the UI components that complete the data flow. After that we will start to work on features around that.
Part of #312
Includes
my-collectibles
component toerc721
sub-app. Basic styling, enough to render a collectible card./src/services
to fetch the corresponding list of collectibles from an API.CollectiblesState
.Does not include