0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Basic "My Collectibles" page #343

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Part of #312

Includes

Does not include

mariano-aguero commented 5 years ago

You can try accessing to the URL http://localhost:3001/erc721/my-collectibles

Agupane commented 5 years ago

Hi @mariano-aguero please check that the branch has conflicts, thanks!

fvictorio commented 5 years ago

This is what I think about the state shape:

First, let's not touch the relayer and market slices. While it bothers me that they are used only for the ERC20 part of the app (because the NFT part also uses the relayer and it's a market), I think we can live with that for now.

Second, I would make some changes to how the CollectibleState is shaped. I think it should be something like:

CollectiblesState {
  userCollectibles: {[tokenId: string]: Collectible}
}

See Normalizing State Shape for the reasoning behind this. I changed myCollectibles to userCollectibles to be more consistent with the naming we've been using so far.

The Collectible interface seems OK enough for now, although it should have an id field, and its price shouldn't be a string.

Agupane commented 5 years ago

Q: Should this pr consider a placeholder for this components?. I mean, no the functionality but the components placed image

unjapones commented 5 years ago

@Agupane

Q: Should this pr consider a placeholder for this components?. I mean, no the functionality but the components placed image

In my opinion no: we initially want to have the UI components that complete the data flow. After that we will start to work on features around that.