Add declining price chart to collectible details

0xProject / 0x-launch-kit-frontend

Apache License 2.0

112 stars 207 forks source link

Add declining price chart to collectible details #412

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

No issue related

Added:

Highcharts to the package json
Add a chart to a collectible if is dutch auction

Should look like this:

Screenshot_20190521_110305

Screenshot_20190521_110346

fvictorio commented 5 years ago

Minor comment: if you set a small expiration time (5 minutes), the chart is updated but the previous dot is not erased:

Right now a user can't set an expiration time that short, but I think we should fix this anyway if it doesn't take too much time.

unjapones commented 5 years ago

Added the question label so this doesn't get merged until the following is resolved:

@chriskalani this graph implementation uses Highcharts. I believe they demand to have a license for commercial usage. Do we want to to proceed and merge this anyway? (we can add a note on the README file).

If not, we can probably check later for another approach to implement the graph.

mariano-aguero commented 5 years ago

Closing in favor of this PR https://github.com/0xProject/0x-launch-kit-frontend/pull/441