search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Enhance error messages #443

Closed pablofullana closed 5 years ago

pablofullana commented 5 years ago

Also hoping the error message can give us more context about what went wrong. I think some error messages are around not having sufficient amounts? If the user doesn't have enough ETH or wETH, it should show an error message like this:

image

burnsben commented 5 years ago

We have this exact type of error message in our current version of 0x instant. Perhaps we can reuse existing components.

burnsben commented 5 years ago

While we're at it, I updated the design to use orange as the background color, and included an error icon

Screen Shot 2019-05-23 at 1 56 52 PM
burnsben commented 5 years ago

realizing I was inspired by (stole from) coinbase pro. Imagining this error will show after the button is clicked. The button will stay orange for 1-2 seconds, and the "you don't have enough ETH" message below will stay for 3-4 seconds.

See coinbase as an example: https://drive.google.com/file/d/1fzDp-laQGdKfBGfZw_HgyhvkstO27-9t/view?usp=sharing