search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Erc721 Background Color Metadata #445

Closed burnsben closed 5 years ago

burnsben commented 5 years ago

Rarebits and open sea have predefined standards for background colors that many/most NFTs support. Would be great to retrieve it from those sources. See: https://docs.rarebits.io/reference and https://docs.opensea.io/docs/2-adding-metadata for reference. And if not attainable, fall back on a standard light gray background color.

Currently looks like we're showing random colors for these? Would prefer to use the metadata, or a consistent light gray instead of going for something more random.

Screen Shot 2019-05-23 at 10 30 50 AM
Agupane commented 5 years ago

Hi @burnsben, we are already using the background color from openSea (we use it on mainnet and rinkeby). For ganache we have hardcoded values. You can see the file with the hardcoded-color values here if you want.

Also, in case openSea does not provides a background color we closed this PR for adding a fallback one. The default value is #FFF. If you wan't from us to change this default color please let me know.

unjapones commented 5 years ago

I forgot to assign this to @burnsben on Friday, as a reminder to pick a default fallback color different from #FFF.

burnsben commented 5 years ago

let's make the fallback color #EBF0F5

burnsben commented 5 years ago

This should be done in conjunction with changing the page background color: https://github.com/0xProject/0x-launch-kit-frontend/issues/481