search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Unstick sticky footer - 721 #486

Closed burnsben closed 5 years ago

burnsben commented 5 years ago

Footer shouldn't go above the content. have this 0x logo show at the bottom of the page underneath all of the content.

Screen Shot 2019-05-28 at 5 00 16 PM
gabitoesmiapodo commented 5 years ago

@burnsben

Could you expand on how you intend this to work? Should the whole section's height grow freely?

I need to be sure because I don't think this is a trivial change: layout is shared between ERC721 and ERC20, so ERC721 inherits the original layout with a fixed height equal to the screen's. Content scrolls between header and footer in this configuration.

If we need different behaviors it may be necessary to create separate layouts (not sure about this yet).

chriskalani commented 5 years ago

Since the content doesn't scroll on ERC-20 it is fine for the footer to always be at the bottom of the viewport. But since ERC-721 does scroll, it doesn't make sense to have content scroll behind the footer. The footer should just come after the content, i.e. it would not show up on the page in the event the page scrolls.