search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Make order expiry date optional #535

Closed icinsight closed 5 years ago

icinsight commented 5 years ago

Now all orders submitted expire in 24 hours, I assume. An improvement would be an option to set an order expiry time, still keeping the default in 24 hours, I have use cases that would benefit greatly from longer or unlimited expiry,

icinsight commented 5 years ago

This is a major obstacle for engagement. Order books are empty and everyone trying to build audience for their assets needs to submit orders every day again and again. The end result is a sad and empty exchange. Please prioritize this or give advice what lines must be changed to change the default (that is hard-coded in as "tomorrow" - bad design choice). This is low effort - high value fix (I would not even call it not even improvement). As it is now it makes the site almost non-usable.

icinsight commented 5 years ago

Make the default "good until canceled" - 15 minute fix.

icinsight commented 5 years ago

It looks this is being worked on in https://github.com/0xProject/0x-launch-kit-frontend/pull/540

Also, I got my edits working (I assume), so let's close this one.