0xProject / 0x-launch-kit-frontend

Apache License 2.0
112 stars 207 forks source link

Not compute correctly WETH unlock value when WETH is the base #595

Open JoaoCampos89 opened 4 years ago

JoaoCampos89 commented 4 years ago

On Weth related to stable coins, it is normal to use Weth as the base. The getWrapEthStepIfNeeded does not handle these cases when WETH is used as base. My workaround was:

Create an isQuote flag and then on the step:

let wethAmountNeeded = isQuote ? amount.multipliedBy(price) : amount;

Before calling the step we need to check if Weth is the quote or base, could be used the following function:

const isWethQuote = isWeth(quoteToken.symbol.toLowerCase()) ? true : false;

At the moment I recommend warning users about this issue saying Weth is not supported as a base token on the config.