search

1000nettles / hey-wait

“Hey, Wait!” is a FoundryVTT module allowing a GM to place “event triggers” on a scene.
https://foundryvtt.com/packages/hey-wait/
MIT License
9 stars 2 forks source link

Consider minifying the built JavaScript code #27

Open ghost91- opened 2 years ago

ghost91- commented 2 years ago

Please consider minifying the built JavaScript code as it helps a lot with reducing load times.

1000nettles commented 2 years ago

Unless something's changed, generally Foundry module / system devs shy away from minification due to it being harder to debug when an issue arises. Are you confident this is slowing things down significantly for you?

ghost91- commented 2 years ago

To be honest, I think they mostly shy away from it because they don’t know any better. Of course just doing it in a single module won’t have a massive effect. But if many modules do, it will be pretty significant.

Regarding it being harder to debug: Are there many situations where the published package needs to be debugged (instead of a non minified development version)? But even if so, it should still be ok if source maps are being utilized.