upkeep/1250: Update actions/upload-artifact from v3 to v4

[Sidsector9]

Description of the Change

Closes #1250

This PR updates actions/upload-artifact from v3 to v4

How to test the Change

Verify with action's run status.

Changelog Entry

Changed - Update actions/upload-artifact from v3 to v4

Credits

Props @Sidsector9

Checklist:

• [ ] I agree to follow this project's Code of Conduct.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my change.
• [ ] All new and existing tests pass.

[github-actions[bot]]

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

[Sidsector9]

Closing as this is already fixed in develop. My local branch was out of date.