search

10up / theme-scaffold

DEPRECATED. Use https://github.com/10up/wp-scaffold
MIT License
184 stars 39 forks source link

Add LightHouse Performance Budget to Scaffold & Github #141

Open dainemawer opened 5 years ago

dainemawer commented 5 years ago

One thing I find frustrating when it comes to performance budgets is that it's a bit of a lost science. No one is really sure how to do it or what to aim for, and it generally ends up being a very manual process of testing, setting goals and then updating a spreadsheet.

With Google LightHouse, we can now add a budget.json in our project and specify performance goals. With the addition of the LightHouse Bot, we can also tie LightHouse into our PR's for features before merging to master to ensure that we are:

a) meeting our budgets b) meeting best practices,

With this process happening during build, rather than scrambling for time in QA. I'd like to propose with @helen help on the Github side, we include the Lighthouse Bot into our pipelines so we can run Lighthouse on PR's as well as integrate a script like npm run lighthouse in our scaffold using a tool like:

https://github.com/GoogleChromeLabs/lighthousebot

dainemawer commented 4 years ago

Looks like Google changed this up a bit, now Lighthouse runs specifically within CI, rather than within a projects infrastructure. I feel like this would probably have to be handled on an organizational level, probably with in @helen and @TheLastCicada territory. I know both of you are super busy, so @timwright12 I think lets put this one on ice for the time being. Unless anyone desperately wants this in 👍