search

11ty / eleventy-plugin-syntaxhighlight

A pack of Eleventy plugins for syntax highlighting in Markdown, Liquid, and Nunjucks templates.
https://www.11ty.dev/docs/plugins/syntaxhighlight/
MIT License
129 stars 32 forks source link

Code highlight is partially failing #29

Closed jpmedley closed 2 years ago

jpmedley commented 4 years ago

Describe the bug I originally opened this but on the web.dev GitHub repo. You asked me to cross-post it here.

An embedded HTML code sample in a new article specifies that lines 3 through 7 should be highlighted. Only lines 3 through 5 are actually being highlighted.

To Reproduce View the rendered article in staging.

image

zachleat commented 2 years ago

Sorry for the super late response here but we did deprecate the line highlighting method we were using here and moved to use the default prism js diff plugin instead. Docs for that here (v3.2.2 and newer): https://www.11ty.dev/docs/plugins/syntaxhighlight/#show-changes-using-diff-syntax

This is an automated message to let you know that a helpful response was posted to your issue and for the health of the repository issue tracker the issue will be closed. This is to help alleviate issues hanging open waiting for a response from the original poster.

If the response works to solve your problem—great! But if you’re still having problems, do not let the issue’s closing deter you if you have additional questions! Post another comment and we will reopen the issue. Thanks!