search

1213-Throwback / Project_5

Project_5
0 stars 0 forks source link

Code Review for Problem 1 #9

Open ghost opened 1 year ago

ghost commented 1 year ago

Just to go over what this code for problem one is doing:

TopBar - image

First, we create a constant that we refer to later when calling a prop that we want to put in the top bar.

Within the return, we put everything inside of an AppBar and a Toolbar. Once we have done this, we create two different variants using a Typography that we use to define what will appear on the left and right sides of the TopBar respectfully. The left variant will simply print the name that we have selected and the right variant will the constant that we defined earlier.

userDetail - image

For this file, we create two constants that we will use later, userId and user. For now, the user uses the windows.model part to pull our props but later in problem two we will change this. The rest of the return function is just calling properties from the user object that we will be displaying on the page.

DiegoLopezInc commented 1 year ago

As a Quality Assurance tester, I want to make sure the code is running without errors. I have tested the following for Problem One in Issue #3 :

• Components/userList component should provide navigation to the user details of all the users in the system. :white_check_mark:

https://github.com/1213-Throwback/Project_5/assets/123400127/cfe18621-d2a3-4d20-afd6-851ab7bb9248

• Components/userDetail component is passed a userId in the props.match by React Router. The view should display the details of the user in a pleasing way along with a link to switch the view area to the photos of the user using the UserPhotos component. :white_check_mark:

• Components/userPhotos component is passed a userId, and should display all the photos of the specified user. :white_check_mark:

https://github.com/1213-Throwback/Project_5/assets/123400127/6bcb6e99-2a14-47d1-a75b-4678654f1ec9

So it looks like: • The left side of the TopBar should have your name. :white_check_mark:

However........ • The right side of the TopBar should provide app context by reflecting what is being shown in the main content region. For example, if the main content is displaying details on a user the toolbar should have the user's name. If it is displaying a user's photos it should say "Photos of " and the user's name. :x:

Other than that, looks good(LGTM)! Problem One SOLVED