search

18F / brand

18F Brand
https://brand.18f.gov
Other
27 stars 21 forks source link

Resolve migrate conflicts #262

Closed igorkorenfeld closed 3 years ago

igorkorenfeld commented 3 years ago

This PR resolves the merge conflicts introduced in #261

Accepting and merging this PR should automatically close #261

👓   Preview

Dahianna commented 3 years ago

Just needs external link identifier. Code can be found here: https://github.com/18F/18f.gsa.gov/pull/3292

igorkorenfeld commented 3 years ago

@Dahianna small issue with this. We currently also have the script for showing a lock icon for links to document which are internal. Both put an icon on the link in the same way, which is resulting them overlapping: image

Three ideas for how we could resolve for now:

  1. We could put the lock icon before the link, (in this case we'd need to remove the slack icon before some links)
  2. Don't use the lock script
  3. Apply the external link icon manually (and don't apply it on locked items)

I can also keep exploring to see if there is another option.

Dahianna commented 3 years ago

We have them both in the 18F site and they don't overlap. I think we configured the external link icon in a way that ignores Slack and social media icons. I'll ask the site team to see how they did it