18F / brand

18F Brand
https://brand.18f.gov
Other
27 stars 21 forks source link

Microsite Identifiers #270

Closed igorkorenfeld closed 2 years ago

igorkorenfeld commented 3 years ago

Create new PRs to update old site "anchor" to new "identifier"

igorkorenfeld commented 3 years ago

Opened a PR for the ux guide, can do similar or share with other guides

afeld commented 3 years ago

Attempt to add to the uswds-jekyll theme, which would allow us to solve the problem in a single place: https://github.com/18F/uswds-jekyll/pull/212

afeld commented 3 years ago

Would you be willing to link to the related pull requests up top, so it's easy to go back and see what changes were required for each?

igorkorenfeld commented 3 years ago

All for that idea but it seem like that PR was stalled and is now closed and that the theme is in maintenance mode. In which case, what would it take to move a new PR through?

And no problem I'll put those links in just a bit.

afeld commented 3 years ago

uswds-jekyll is in maintenance mode because there hadn't been anyone available to make active improvements on it. If you're doing that work anyway (across the sites), we would more than welcome the help on the theme, especially since that would cut out complexity/maintenance elsewhere.

what would it take to move a new PR through?

Getting it merge-able! I think it was close.

igorkorenfeld commented 3 years ago

Awesome, that helps clarify. I'll take a look at replicating what I've done compared to the older PR and hopefully push something up.

Dahianna commented 3 years ago

Dahianna will follow up with teams to make sure they merge PR

igorkorenfeld commented 3 years ago

Footer / identifier merged into USWDS-Jekyll

cannandev commented 2 years ago

@igorkorenfeld Is this issue ok to close out? I think it was waiting on https://github.com/18F/ux-guide/pull/265 6/30), which has been merged.

igorkorenfeld commented 2 years ago

Yes, thank you!