1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
90 stars 73 forks source link

exposes loglevel of connect components #135

Closed akohlmann closed 1 year ago

akohlmann commented 1 year ago

Exposes env vars to set loglevel for api and sync components

hpatel826 commented 1 year ago

I think this is a good solution for https://github.com/1Password/connect/issues/44 instead of changing the connect application's logging levels. Our company also uses Datadog where some systems conform to the syslog level field, but 1Password does not.

pesoos commented 1 year ago

@jpcoenen please review

akohlmann commented 1 year ago

Hey! Thanks for this contribution. Simple but definitely useful.

What do you think about using logLevel instead of loglevel? I think it's to a bit more in line with the other values. If you agree, you can just accept all my change suggestions :)

@jpcoenen totally reasonable, thanks for the improvements 🙏

jpcoenen commented 1 year ago

I just wanted to merge this, but I see this PR has some unsigned commits.

To get your PR merged, please sign all commits (git commit -S --amend --no-edit) and then force push them to this branch (git push --force-with-lease). Apologies for the inconvenience!

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with `gpg`: 1. [Generate a GPG key](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key) 2. [Add the GPG key to your GitHub account](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account) 3. [Configure `git` to use your GPG key for commits signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-gpg-key)
Sign commits with ssh-agent

Follow the steps below to set up commit signing with `ssh-agent`: 1. [Generate an SSH key and add it to `ssh-agent`](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent) 2. [Add the SSH key to your GitHub account](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account) 3. [Configure `git` to use your SSH key for commits signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key)
Sign commits with 1Password

You can also sign commits using [1Password](https://developer.1password.com/docs/ssh/git-commit-signing/): Watch the demo
akohlmann commented 1 year ago

I just wanted to merge this, but I see this PR has some unsigned commits.

To get your PR merged, please sign all commits (git commit -S --amend --no-edit) and then force push them to this branch (git push --force-with-lease). Apologies for the inconvenience!

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg Sign commits with ssh-agent Sign commits with 1Password

@jpcoenen done, also thanks for the 1Password commit signing tip, awesome feature 🚀