Closed akohlmann closed 1 year ago
I think this is a good solution for https://github.com/1Password/connect/issues/44 instead of changing the connect application's logging levels. Our company also uses Datadog where some systems conform to the syslog level
field, but 1Password does not.
@jpcoenen please review
Hey! Thanks for this contribution. Simple but definitely useful.
What do you think about using
logLevel
instead ofloglevel
? I think it's to a bit more in line with the other values. If you agree, you can just accept all my change suggestions :)
@jpcoenen totally reasonable, thanks for the improvements 🙏
I just wanted to merge this, but I see this PR has some unsigned commits.
To get your PR merged, please sign all commits (git commit -S --amend --no-edit
) and then force push them to this branch (git push --force-with-lease
). Apologies for the inconvenience!
If you're new to commit signing, there are different ways to set it up:
gpg
ssh-agent
I just wanted to merge this, but I see this PR has some unsigned commits.
To get your PR merged, please sign all commits (
git commit -S --amend --no-edit
) and then force push them to this branch (git push --force-with-lease
). Apologies for the inconvenience!If you're new to commit signing, there are different ways to set it up:
Sign commits with
gpg
Sign commits withssh-agent
Sign commits with 1Password
@jpcoenen done, also thanks for the 1Password commit signing tip, awesome feature 🚀
Exposes env vars to set loglevel for api and sync components