1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
90 stars 73 forks source link

FEAT: Support imagePullSecrets in connect chart #144

Open alexbescond opened 1 year ago

alexbescond commented 1 year ago

Context

The helm chart support changing the container registry. However, it does not support imagePullSecrets which means that the images on our private registry must be public.

Proposal

Add this imagePullSecrets on the connect and operator deployment. By default, there is nothing but we can add this value if we want to use private registry.

tomjo commented 1 year ago

We're also interested in this as we would like to pull the image through our registry proxy to not hit dockerhub rate limiting. Another option to set the imagePullSecrets would be attaching them to a specific serviceaccount but this is also not configurable for connect.