search

1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
90 stars 73 forks source link

Make Connect Service k8s resource type configurable #65

Closed parente closed 2 years ago

parente commented 3 years ago

I noticed the connect chart had default values for service.type and service.port that went unused. Having the ability to create a ClusterIP service for use inside our cluster only rather than NodePort exposed on the node IPs better fits our use case.

This PR cleans up the unused service.* default values and adds connect.serviceType, defaulted to NodePort to match the hardcoded value, for this purpose.

eddiezane commented 3 years ago

I'd like to see ClusterIP be the default value. Users should explicitly opt in if they want to expose this outside of their cluster.