1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
90 stars 73 forks source link

Add annotations to the service template #87

Closed dkamenov-fitted closed 1 year ago

dkamenov-fitted commented 2 years ago

Adding annotations to the service helm template. This was something I needed to be able to support backend configuration in order to run this within a GKE instance.

ahanselka commented 2 years ago

I'd like to see this as well. Annotations on services seems to be a fairly important feature that I'm kinda surprised this helm chart is missing.

@dkamenov-fitted It might be worth creating a new variable like Values.connect.serviceAnnotations instead of just re-using Values.connect.annotations since you don't necessarily want the same annotations for the deployment and the service. Either way though, thanks for this PR! Hopefully it actually gets merged someday 😅