1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
90 stars 73 forks source link

Add support for existing credentials #98

Open otherguy opened 2 years ago

otherguy commented 2 years ago

Summary

It would be great if we could specify e.g. operator.existingTokenSecret and connect.existingCredentialsSecret when installing the Helm chart

Use cases

I use this with ArgoCD and don't want the credentials/token in my Git repository.

Proposed solution

Specifying the name of a Secret with the existing token should negate the need to specify token/credentials on every install.

onedr0p commented 2 years ago

This would be awesome, but it seems like the maintenance of this repo is lacking :/

nklmilojevic commented 2 years ago

Same problem with our usage at MailerLite. We imported it into Flux, but as soon as we updated the version, it broke cause it requires files each time. Please provide a mechanism for using an existing secret.

Apollorion commented 2 years ago

I know this is old, so it may just be outdated. But I installed this no problem with a existing credentials (also using flux). If you just dont set connect.credentials or operator.token.value neither secret will be created and you can use an existing secret.

jillianwilson commented 1 year ago

Apologies for the slow movement on this issue, we have tracked this internally to look into adding in the future. We will update you when this has been implemented. In the meantime, is the solution that @Apollorion provided satisfactory?