1dot13 / gamedir

Game assets for the Jagged Alliance 2 v1.13 project
14 stars 12 forks source link

Wrong facing tile in StructureConstruct.xml #81

Closed Coelancanth closed 3 months ago

Coelancanth commented 3 months ago

Should be

<STRUCTURE><!--concertina wire-->
        <usCreationItem>1542</usCreationItem>
        <usItemStatusLoss>1</usItemStatusLoss>
        <szTileSetDisplayName>Concertina wire</szTileSetDisplayName>
        <szTileSetName>spot_1.sti</szTileSetName>
        <dCreationCost>1.0</dCreationCost>
        <fFortifyAdjacentAdjustment>1</fFortifyAdjacentAdjustment>
        <northfacingtile>2</northfacingtile>
        <northfacingtile>4</northfacingtile>
        <southfacingtile>2</southfacingtile>
        <southfacingtile>4</southfacingtile>
        <eastfacingtile>3</eastfacingtile>
        <eastfacingtile>5</eastfacingtile>
        <westfacingtile>3</westfacingtile>
        <westfacingtile>5</westfacingtile>

instead of

<STRUCTURE><!--concertina wire-->
        <usCreationItem>1542</usCreationItem>
        <usItemStatusLoss>1</usItemStatusLoss>
        <szTileSetDisplayName>Concertina wire</szTileSetDisplayName>
        <szTileSetName>spot_1.sti</szTileSetName>
        <dCreationCost>1.0</dCreationCost>
        <fFortifyAdjacentAdjustment>1</fFortifyAdjacentAdjustment>
        <northfacingtile>3</northfacingtile>
        <northfacingtile>5</northfacingtile>
        <southfacingtile>3</southfacingtile>
        <southfacingtile>5</southfacingtile>
        <eastfacingtile>2</eastfacingtile>
        <eastfacingtile>4</eastfacingtile>
        <westfacingtile>2</westfacingtile>
        <westfacingtile>4</westfacingtile>

tldr: should be 2424, 3535. Instead of 3535,2424

kitty624 commented 3 months ago

co3-5 concertina in spot_1.sti looks like that

I'm not realy sure ...

kmoiwyh commented 3 months ago

co3-5 concertina in spot_1.sti looks like that

I'm not realy sure ...

It is incorrect. Wrong direction feedback in the game. bad1

kitty624 commented 3 months ago

concertina compared xml - in game

I don't see any issue with the existing xml

kmoiwyh commented 3 months ago

Concertina wire

Please use the defensive fortification function

Uploading Wrong direction of Concertina wire.mp4…

kitty624 commented 3 months ago

Concertina wire

Please use the defensive fortification function

Uploading Wrong direction of Concertina wire.mp4…

https://github.com/1dot13/gamedir/assets/58940527/ccd29f2c-5d6c-4334-bdcd-f8f8d2e5ed83

Did use it and found the culprit

It's not the index, it's the tag fFortifyAdjacentAdjustment

If this tag is 1, game tries to align adjacent tiles Which will look kinda ok with sandbags, but just looks wrong with concertina The way the actual graphics for concertina look like and are sorted in .sti-file isn't realy suited for that

in the video I've set that tag for concertina to fFortifyAdjacentAdjustment>0</fFortifyAdjacentAdjustment and that way things look ok to me

index has been unchanged, if that would be changed as suggested in initial post, things then will look wrong if we place them by hand

can you test this on your side? (keep original index, but change fFortifyAdjacentAdjustment for concertina from 1 to 0)

kmoiwyh commented 3 months ago
0

fFortifyAdjacentAdjustment for concertina from 1 to 0 Alright, there's no problem now. Solved.

kitty624 commented 3 months ago

https://github.com/1dot13/gamedir/pull/89

committed change to solve the issue