search

1up-lab / OneupUploaderBundle

This Symfony bundle provides a server implementation for handling single and multiple file uploads using either FineUploader, jQuery File Uploader, YUI3 Uploader, Uploadify, FancyUpload, MooUpload, Plupload or Dropzone. Features include chunked uploads, orphanages, Gaufrette and Flysystem support.
MIT License
603 stars 177 forks source link

Is this bundle compatible (or when will be?) with Symfony 4? #297

Closed Lifeformwp closed 6 years ago

Lifeformwp commented 6 years ago

Hello, when I trying to install this bundle on my 4.0.0-RC1 composer gives me error that v3.4 is minimum-stability. Will you support ^4 and when? Or am I doing something wrong?

bytehead commented 6 years ago

There is a PR #295, but the tests do still fail and it's not yet complete. But the goal is to support ^4.0

Lifeformwp commented 6 years ago

Thank you!

klodoma commented 6 years ago

Any timeline when you will release the support for Symfony4? As I see it's already developed in a branch. Thx.

bytehead commented 6 years ago

@Lifeformwp @klodoma There's a release/2.0.0-branch - could you test and give feedback if possible?

klodoma commented 6 years ago

@bytehead I will give it a try the next days as we plan to upgrade to Symfony4. I'll provide my feedback.

bytehead commented 6 years ago

Thank you, I'll await your feedback!

klodoma commented 6 years ago

Hi, so my current feedback... , I am aborting the upgrade of our project to 4. There are too many dependencies in the project that are currently failing the upgrade.

Still, if I'll find some spare time I'll give it a shot and test your bundle on Symfony4.

soifou commented 6 years ago

@bytehead I'm testing your release/2.0.0 branch and no problem to report so far 👍

I only had to create package and routing files in config/. You plan to create a contrib recipe for it, right?

ErnadoO commented 6 years ago

Hello @bytehead

i'm testing release/2.0.0 too and i found one thing.

Like in your documentation, I use Orphanage like this: $manager = $this->get('oneup_uploader.orphanage_manager')->get('products');

But Sf4 don't like it:

The "oneup_uploader.orphanage.products" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

I had fix it, i will send a PR soon ;)

francoispluchino commented 6 years ago

@bytehead For me, it's ok, but the PR #311 must be merged. When will the 2.0 version be released in stable?

bytehead commented 6 years ago

@soifou Thanks for your feedback! It is planned, but I don't know, when I have time for it. Wanna create a PR? 🙂

@francoispluchino #311 is merged. I think we should also provide a contrib receipe before release the stable 2.0.

soifou commented 6 years ago

@bytehead PR done, waiting for 2.0 version to be released :)

bytehead commented 6 years ago

Thank you! I'll release 2.0 asap!

bytehead commented 6 years ago

Version 2.0.0 is out! Thanks to everyone involved! 🎉