2amigos / yii2-editable-widget

X-Editable Widget for Yii2
Other
58 stars 20 forks source link

More dependinces from Select2 #10

Closed loveorigami closed 9 years ago

loveorigami commented 9 years ago

Dear Antonio! After installing editable-widget I have more dependinces from Select2. It is not good, because I not use Simfony, components etc.From one of them I have mistake in console...

Please, correct dependencies with Select2. May be better use Select2 as bower without composer dependencies?

tonydspaniard commented 9 years ago

Hi @loveorigami do you mean that Select2 has more dependencies that the ones included? Is true that I have to change the way is inserted and make use of bower-asset from Yii2 but that shouldn't be the problem or is it? What has changed?

Thank you

loveorigami commented 9 years ago

Before installing I have in vendor clear structure

after installing I have not used dependencies from select2:

after

loveorigami commented 9 years ago

and after removing I have error in console after2

loveorigami commented 9 years ago

After command: bower i select2 -save I have only select2 without composer dependencies bower

loveorigami commented 9 years ago

may be better use "bower-asset/select2": "~3.5.0" instead of "ivaynberg/select2": "3.5.0" https://github.com/2amigos/yii2-editable-widget/blob/master/composer.json#L16

and public $sourcePath = '@vendor/bower/select2'; instead of public $sourcePath = '@vendor/ivaynberg/select2'; here https://github.com/2amigos/yii2-editable-widget/blob/master/Select2Asset.php#L21

tonydspaniard commented 9 years ago

Thank you for such valuable information @loveorigami will update asap

SDKiller commented 9 years ago

+1

Numerous dependencies, including extra jquery + installation via component-installer vs single bower package

qip shot - screen 568 20 02 15