search

2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)
MIT License
947 stars 82 forks source link

Squashed commit of adding documentation wraper class and updating Dem… #101

Closed engineer-pearl closed 1 year ago

engineer-pearl commented 2 years ago

Pull request with squashed commits for #97

Original comments:

I've been careful not to take too much liberty with the documentation, but I added a little extra where I thought it was needed (like the insert_rows function). Someone with a background in technical documentation probably could have done better.

Functionality wise, clicking on functions brings you to where they're defined, and godot can auto-complete function names. I'd say this means I've accomplished the two biggest goals for this helper class.

I'm not too happy with the file name, file location, or class name though, and am open to suggestions if you've got them.

Do you think the demo project you've written is a sufficient test to ensure the class is feature complete, or are there additional test cases you would recommend I add?

2shady4u commented 1 year ago

Hi @engineer-pearl,

The demo project has been sufficient for a long time now, but I certainly see the advantage of, at some point, implementing some actual unit testing (probably using GUT).

I can close this one due to it being outdated?

engineer-pearl commented 1 year ago

Yeah, you can close it.

The demo provides some pretty solid integration tests, but I can see how formal tests would be quite powerful.