2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)
MIT License
850 stars 76 forks source link

Extension doesn't load since 4.1 beta 2 #148

Closed koenheltzel closed 1 year ago

koenheltzel commented 1 year ago

Environment:

Issue description:

Steps to reproduce: Open & run the godot-sqlite demo project in Godot 4.1 beta 2 or 3

Output when opening the demo project:

  core/extension/gdextension.cpp:593 - GDExtension configuration file must contain a "configuration/compatibility_minimum" key: res://addons/godot-sqlite/gdsqlite.gdextension
  Failed loading resource: res://addons/godot-sqlite/gdsqlite.gdextension. Make sure resources have been imported by opening the project in the editor at least once.
  editor/editor_data.cpp:880 - Index p_idx = -1 is out of bounds (edited_scene.size() = 1).
  editor/editor_data.cpp:683 - Index p_idx = -1 is out of bounds (edited_scene.size() = 1).
  editor/editor_data.cpp:745 - Index p_idx = -1 is out of bounds (edited_scene.size() = 1).
  res://database.gd:3 - Parse Error: Could not find type "SQLite" in the current scope.
  res://database.gd:5 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:5 - Parse Error: Assigned value for constant "verbosity_level" isn't a constant expression.
  res://database.gd:55 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:159 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:227 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:276 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:331 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:370 - Parse Error: Identifier "SQLite" not declared in the current scope.
  res://database.gd:390 - Parse Error: Identifier "SQLite" not declared in the current scope.

Error popup when running the demo project: 2023-06-22 10_24_10-Main tscn - SQLite Demo - Godot Engine

thearduinoguy commented 1 year ago

I have the same issue using 4.1 Beta 3

2shady4u commented 1 year ago

Hello @thearduinoguy and @koenheltzel

There's no release of godot-cpp yet for Godot 4.1 so I can't compile godot-sqlite for that version yet...

thearduinoguy commented 1 year ago

FYI it works with Godot 4.1 Beta 1 but not later versions.

go-stuff commented 1 year ago

Good morning, just looked at the godot-cpp repo and it has a warning that the master branch is for 4.1

Warning This repository's master branch is only usable with the latest version of Godot's (GDExtension) API (Godot 4.1 and later).

cyberpuffin-digital commented 1 year ago

Master branch has the warning, there's also a 4.1 branch and tag (https://github.com/godotengine/godot-cpp/releases/tag/godot-4.1-stable).

thearduinoguy commented 1 year ago

Thanks. So this will work with today's Godot release?

On Thu, 6 Jul 2023, 18:07 Tim, @.***> wrote:

Master branch has the warning, there's also a 4.1 branch and tag ( https://github.com/godotengine/godot-cpp/releases/tag/godot-4.1-stable).

— Reply to this email directly, view it on GitHub https://github.com/2shady4u/godot-sqlite/issues/148#issuecomment-1624019642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCFQJ7SWWW7JTCX3G4PIDXO3WF3ANCNFSM6AAAAAAZP3ACYQ . You are receiving this because you were mentioned.Message ID: @.***>

JonnyTech commented 1 year ago

+1 from me, 4.1 fixes some bugs that I encountered so would love to see a build targetting it

git2013vb commented 1 year ago

It will ask to add this row under [configuration] compatibility_minimum = 4.1.0

But if I follow the source code in demo folder and I set instead compatibility_minimum = 4.1 godot will crash

Still, after setting the correct key I still have the error:

core/extension/gdextension.cpp:628 - No GDExtension library found for current OS and architecture (linux.x86_64) in configuration file: res://addons/godot-sqlite/gdsqlite.gdextension

artcattleya commented 1 year ago

I have error (core/extension/gdextension.cpp:593) too with 4.1 Godot release

2shady4u commented 1 year ago

Hello everyone, I've updated the source code to be compatible with Godot 4.1 You can find the binaries here: https://github.com/2shady4u/godot-sqlite/actions/runs/5479060666

You'll also have to use the updated gdsqlite.gdextension as found here: https://github.com/2shady4u/godot-sqlite/blob/gd-extension/demo/addons/godot-sqlite/gdsqlite.gdextension

I'll do a release soon as well.

2shady4u commented 1 year ago

A new release has been made for Godot v4.1 and can be found here: https://github.com/2shady4u/godot-sqlite/releases/tag/v4.2

If there's any new issues with this release, please open a new issue 😄

thearduinoguy commented 1 year ago

How can I install this version please? It is not available in the Asset Library.

JonnyTech commented 1 year ago

Yes it is...

image

thearduinoguy commented 1 year ago

Sorry my bad! Thanks for fixing this issue and making it work with 4.1