Deprecate and remove index_subsystem

389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux

https://www.port389.org/

Other

213 stars 94 forks source link

Deprecate and remove index_subsystem #2434

Open 389-ds-bot opened 4 years ago

389-ds-bot commented 4 years ago

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49375

Created at 2017-09-08 07:31:12 by firstyear (@Firstyear)
Assigned to nobody

Issue Description

We have a plugable index subsystem, however we don't use it anywhere in the code base. In the past it provided the ability to assign functions to filters to allow out-of-band indexes. However now all it provides was a filter-fold mechanism (which the new filter optimiser replaces).

Since we have no users of this subsystem, we should deprecate and remove this. I do not foresee us accepting pluggable indexes again, as there is little community or commercial interest.

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2017-09-14 17:35:58

Metadata Update from @mreynolds389:

Custom field component adjusted to None
Custom field origin adjusted to None
Custom field reviewstatus adjusted to None
Custom field type adjusted to None
Custom field version adjusted to None
Issue set to the milestone: 1.4 backlog

389-ds-bot commented 4 years ago

Comment from firstyear (@Firstyear) at 2017-10-31 04:54:15

@elkris Do you have thoughts on this ?

droideck commented 3 months ago

@Firstyear I see that the filter optimizations have a long history (There was a commit in 2017, then it was reverted in 2018, then it was brought back in 2022 and then there was a performance drop found and the issue is still open)

In the recent commit, there is index_subsystem.c added by you. Do you mean to deprecate that? I'm a bit lost here, so I'll appreciate a bit more details and if you think it's still worth doing this in your opinion.

vashirov commented 3 months ago

The code was removed in https://github.com/389ds/389-ds-base/commit/8d51c979f247c90bc0d005ec4edc821558ee7a28, but brought back in https://github.com/389ds/389-ds-base/commit/90d847426bf64cb5f2f2fd957f928be01d0500f8. The server builds without this file, so we should remove it again, as it seems it was brought back by mistake.