3DSinghVFX / animation_nodes

Node-based visual scripting system designed for motion graphics in Blender.
Other
155 stars 16 forks source link

Performance of the Simulation Nodes #175

Closed 3DSinghVFX closed 3 years ago

3DSinghVFX commented 3 years ago

Continue from: https://github.com/3DSinghVFX/animation_nodes/issues/174#issuecomment-851215427

@Gerstmann-Bradley I'm using Ubuntu 18.04 LTS and Blender 2.93, I'm getting 24FPS for the Simulation Input node as well as with Simulation Output node: Screenshot from 2021-06-01 10-05-36

Screenshot from 2021-06-01 10-07-56

Gerstmann-Bradley commented 3 years ago

that's nice. I'm not sure the reason then. I can only tell that i'm on windows 10.

3DSinghVFX commented 3 years ago

that's nice. I'm not sure the reason then. I can only tell that i'm on windows 10.

Okay. I'll look into that, and I'll also ask someone for Mac OS as well.

Gerstmann-Bradley commented 3 years ago

that's nice. I'm not sure the reason then. I can only tell that i'm on windows 10.

Okay. I'll look into that, and I'll also ask someone for Mac OS as well.

I guess I have found out the reason, but it's little difficult for me to understand why it happens exactly. Would you please try this file to see the FPS? The problem is there are some node tree that contains lots of group node and loop node. These aren't being executed. Nevertheless their presence seems to impact simulation node somehow. If I remove these node trees, FPS goes back to 30.

Simulation BUG.zip

OmarEmaraDev commented 3 years ago

This is due to expensive searches of nodes. Might be redundant, we will need to investigate this further. Not time at the moment, but here is a flamegraph.

Flamegraph

3DSinghVFX commented 3 years ago

This is due to expensive searches of nodes. Might be redundant, we will need to investigate this further. Not time at the moment, but here is a flamegraph.

Flamegraph

@OmarEmaraDev Thanks. One thing I would like to add is that, if a node-tree has a large number of nodes and visible while playing animation, it also drops the FPS. Is that also related to searches of nodes?

OmarEmaraDev commented 3 years ago

@3DSinghVFX No. It takes time to draw those nodes on the screen, so each visible node adds to the render time and reduces FPS.

3DSinghVFX commented 3 years ago

@3DSinghVFX No. It takes time to draw those nodes on the screen, so each visible node adds to the render time and reduces FPS.

Okay.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Gerstmann-Bradley commented 3 years ago

I think this post should be set "Pending". Since this an issue that's not being investigated for the moment.

OmarEmaraDev commented 3 years ago

@Gerstmann-Bradley Can you create an issue in the main repository so that we can track it better?