kfarr
commented
1 month ago meta comments:
- Before this PR, the state was duplicated across both React and A-Frame components with with Kieran and Alex's "spaghetti code." After this PR state is still duplicated, but there is a lot less spaghetti code and some things are much simpler such as handling of author. Active scene ID, title, author, etc. is probably a candidate for zustand or similar state management system when the time is right.
testing results:
I have a hard time testing the core issue of the "race conditions" of async preview generation not compatible
Instead, I have tested the following to see what is the outcome for preview image generation and uploading:
- ⭐ press save button when not logged in (then logging in with either google or msft) -- results in uploading black box for thumbnail (if no prior screenshots taken) OR uploading the previously captured image (if successfully saved a capture earlier in the same session) [1] this is confusing as it could be a thumbnail from a scene that is not currently loaded. (ie a black box would be better than the incorrect thumbnail).
- when logged in, open another user's scene, then press "save as" from another user's scene -- WORKS as expected
- ⭐ when logged in, open another user's scene, then move an item, then change the title in the title popup from another user's scene -- RESULT in no thumbnail [2] (different than black, this is not uploading any thumbnail)
- when logged in, open my own scene, then press "save as" from my own scene -- WORKS as expected
- ⭐ when logged in, open my own scene, then click share, then click "Set as scene thumbnail" Now I no longer see a success message after uploading (unless I look at console log) and I may think that something has gone wrong. I do see an unauthorized error if it is raised, which is expected behavior (if I attempt to change the thumbnail of a scene that is not my own)
screenshots:
[1] see left thumbnail
[2] see left thumbnail
one interesting thing here is that screenshots are only set on the first time a scene is saved. won't this cause drift with the screenshot and what the user has created?
EDIT: actually, this relates to "set scene thumbnail". I dont think we need to ask the user to do this and instead we should just do this for the users ourselves.