3F / DllExport

.NET DllExport with .NET Core support (aka 3F/DllExport aka DllExport.bat)
MIT License
968 stars 133 forks source link

Source: Configurator/ConfVersion.cs is not checked in currently #31

Closed HeikoStudt closed 7 years ago

HeikoStudt commented 7 years ago

Hi,

in the source code: The file Configurator/ConfVersion.cs is missing and was probably not checked in.. For the moment the master does not compile.

MFG

3F commented 7 years ago

looks normal: https://ci.appveyor.com/project/3Fs/dllexport/branch/master

Read:

Configurator/ConfVersion.cs will be generated via vssbe scripts. Current active Events/Actions:

 3 / 3] Pre-Build      :: [!][!][!]
 3 / 3] Post-Build     :: [!][!][!]
 0 / 0] Cancel-Build   :: 
 0 / 0] CommandEvent   :: 
 0 / 0] Warnings-Build :: 
 0 / 0] Errors-Build   :: 
 0 / 0] Output-Build   :: 
 1 / 1] Sln-Opened     :: [!]
 0 / 0] Sln-Closed     :: 
 0 / 0] Transmitter    :: 
 0 / 0] Logging        :: 
...
action 'define dynamic constants'
action 'Prepare output directory'
action 'Update version number'
action 'Update ConfVersion'      <<<<<<<<<<<<<<<<<<
action 'Binaries & tools ...'
action 'Provide our ILAsm & ILDasm'
action 'Packing with GetNuTool ...'
...

If you just want to get binaries, use:

> build

You do not need any plugins because of CIM version.

For support this via VisualStudio IDE you should have installed plugin.

For coreclr: Make sure that you have installed CMake, then build_coreclr_x86_x64.cmd etc.

upd:

by the way, yes ... No requires additional steps for you, just build as you need. it was before :) need to update readme

HeikoStudt commented 7 years ago

Thanks for the fast answer. I didn't see that the build.bat was required as a first step. It would be nice to change the filename to be "ConfVersionGenerated.cs" or such, so that one has some clue. After I have started build.bat once, I can compile the Configurator.

MFG

3F commented 7 years ago

@HeikoStudt

I didn't see that the build.bat was required as a first step

it's not a first step :) this for build via console (including CI etc.) by CIM version.

for Visual Studio, see this

"ConfVersionGenerated.cs"

I'm not sure that's will be more clear, so probably to change this with another logic is better. For example like I did it for Conari project:

public const string S_REV = "39634";
...
public const string BRANCH_SHA1 = "aa4e6b1";
public const string BRANCH_NAME = "master";
public const string BRANCH_REVC = "45";
...

this way helps to avoid changing for SCM from common user-builds

Well, I'll look this later

3F commented 7 years ago

now it's part of this repo: SHA1 & rev will be updated only when PublicRelease cfg is used