3KUdelta / Solar_WiFi_Weather_Station

Based on the work of Open Green Energy: First solar Zambretti Forecaster
111 stars 50 forks source link

Missbehavior in creating wifi connection #35

Closed f45tb00t closed 4 years ago

f45tb00t commented 4 years ago

Hello,

I am not sure if this was implemented intentionally or by mistake. But your code opens unwanted Open and unencrypted APs after wake up. I consider this as a potential security issue.

If it was made by design. Why?

To fix this issue you can add the following (or change partially the code)

Example: WiFi.mode(WIFI_STA); WiFi.hostname(DEVICENAME); WiFi.begin(ssid, pass);

The WiFi.mode(WIFI_STA); must be added before the WiFi.begin(ssid, pass);

Kind Regards

fastboot

3KUdelta commented 4 years ago

Hi fastboot, thank you for this hint. Definitely a mistake. I will change accordingly. Marc