Closed Ali-Kabbadj closed 2 years ago
petrspelos
commented
2 years ago @Ali-Kabbadj I think you just force-pushed into this branch so you undid a little bit of your work. 😅
That's because as you were applying suggestions here on GitHub, they were being committed into your branch. I'll quickly suggest what we mentioned before again.
So be sure to pull the changes first before you try to push them. ☺️
petrspelos
commented
2 years ago Actually, @Ali-Kabbadj now I see what happened. You must have opened a new PR.
Just push into your branch and the old PR will still update. I'll close this one, no worries.
Ali-Kabbadj
commented
2 years ago @petrspelos , I'm really sorry ! i was trying to find a way to remove the pull request and fix my mistake
petrspelos
commented
2 years ago No problem at all. What you'd ideally want to do is now pull changes on your Update_Difficulty_Attribute branch. And then make and push your changes. The previous pull request should update automatically with your changes. ☺️
Be careful since you now have both Update_difficulty_attribute branch and Update_Difficulty_Attribute. So be sure to push into the right one. 😅
75
Summary
Changed the value assigned to difficultly to 150 To fix test failing
Types of changes
Testing
Test was failing after changing difficulty range from (1-5) to (0-100)
Notes
@petrspelos i'm not sure i know how to modify the test to try two different out of range values , i could try and look it up later to implement it ,for now how this will do to fix the failing test