search

3liz / lizmap-plugin

Lizmap plugin for QGIS, allowing to publish QGIS maps to Lizmap Web Client
https://www.lizmap.com/
GNU General Public License v2.0
63 stars 31 forks source link

Use True boolean instead of string boolean in CFG file #176

Open nboisteault opened 5 years ago

nboisteault commented 5 years ago

Description

Today .cfg contain "True" or "False" for boolean which we'll fix in Lizmap 4. Should we keep this way to do until Lizmap 4 ?

@rldhont @mdouchin Thoughts ?

mdouchin commented 5 years ago

we should keep the old and bad way, until we change it for Lizmap 4

Gustry commented 5 years ago

Yes, we should switch one day to a proper JSON with boolean as bool.

I made a kind of hack in the multiatlas branch. If a single atlas was setup, it was generating the same CFG as before, with boolean as strings. But if it's a multi atlas, as it's a new data structure, I was at the same time using proper boolean in the new config. This doesn't break existing config with existing LWC. But yes maybe @mdouchin is right and we should postpone to Lizmap 4 this kind of change?

Gustry commented 5 years ago

Ok, so from this comment https://github.com/3liz/lizmap-plugin/pull/170#issuecomment-557162960 I will rollback the change.

3liz-bot commented 4 years ago

Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Thanks for being a part of the Lizmap community! 🦎

Gustry commented 1 year ago

Some cleaning as been done in e71d9b2298905fdd0c11e03b0c61a48e35b816ef and cd423b64f8629f68e0460953146c1802aa25d9d3