search

3raxton / spicetify-custom-apps-and-extensions

A community-driven collection of custom apps for Spicetify (https://github.com/khanhas/spicetify-cli)
Other
187 stars 23 forks source link

Add extension for skipping sad songs #2

Closed JakeRoggenbuck closed 3 years ago

JakeRoggenbuck commented 3 years ago

@3raxton Yeah, sure thing! I added the stuff in listed in the CONTRIBUTING.md. Thanks so much!

3raxton commented 3 years ago

This looks good! There may be a problem with the picture, but I can't be sure until I merge. I'll keep you updated. Also, to confirm, you don't want to add anything to AUTHORS.md?

JakeRoggenbuck commented 3 years ago

Thanks! I added my extension and name to the AUTHORS.md.

3raxton commented 3 years ago

All is looking good! Thanks for keeping this in line with the current files' look; I appreciate it as tedious as it may have been. Glad to have you as part of the repo; this PR is merged!

JakeRoggenbuck commented 3 years ago

Yay! Thank you!

3raxton commented 3 years ago

One thing to note here, the screenshot is not hosted correctly. I believe the adequate approach is hosting it in your forked repo and then committing it as another PR. Would you mind doing that?

3raxton commented 3 years ago

@JakeRoggenbuck

JakeRoggenbuck commented 3 years ago

Sure, I can do that!

JakeRoggenbuck commented 3 years ago

Done in #6

3raxton commented 3 years ago

Good stuff, appreciate the fast response!