search

3rd-party-integrations / github-team-sync

Sync GitHub teams to groups in Active Directory, LDAP, Okta, OneLogin or AzureAD when using any authentication method for GitHub.
MIT License
201 stars 67 forks source link

LDAP_SERVER_PORT currently unused #124

Open Robbilie opened 2 years ago

Robbilie commented 2 years ago

LDAP_SERVER_PORT is currently not used and the port and protocol has to be included in the LDAP_SERVER_HOST the PORT env var has to be set though otherwise an error is thrown

https://github.com/github/github-team-sync/issues/124#tasklist-block-1aaf0167-d8f3-4130-b3cc-0ef4cbbf0161

primetheus commented 2 years ago

@Robbilie it looks like we implemented the variables, but only use the LDAP_SERVER_HOST when making the connection. This should be a simple fix. I'll try to get that kicked out this week

primetheus commented 2 years ago

This line is where the server connection is initialized, so we need to incorporate some pre-init logic to build an ldap3.Server instance and use that instead of the environment variable