Tidy up dockerfile - Githubissues

3rd-party-integrations / github-team-sync

Sync GitHub teams to groups in Active Directory, LDAP, Okta, OneLogin or AzureAD when using any authentication method for GitHub.

MIT License

201 stars 67 forks source link

Closed NotActuallyTerry closed 3 months ago

NotActuallyTerry commented 3 months ago

This PR rearranges & tidies up the Dockerfile to achieve a few things:

Avoids longer rebuilds on code change by copying the pipfile in, running install, then copying the code in
Significantly reduces the image size by removing unnecessary development libraries
Fixes up a few warnings thrown by buildx

Testing locally, a fresh build now takes 7 seconds less (31s vs 38s) & uses less than 25% of the space (296MB vs 1.38GB)

primetheus commented 3 months ago

thanks for this @NotActuallyTerry! 🎉