search

3rdparty / eventuals

Apache License 2.0
34 stars 7 forks source link

Remove a bunch of annoying clang-tidy checks #588

Open NikitaNikolaenko opened 1 year ago

NikitaNikolaenko commented 1 year ago

Removes the following very annoying checks:

  1. modernize-use-trailing-return-type - this check constantly notifies about an option to use smth like this:

    auto add_two_values(int a, int b) -> int

    Useless and is not used in eventuals codebase.

  2. readability-function-cognitive-complexity - eventuals by their nature have extremely complex codebase, some of the functions have a cognitive complexity of 300+, this check acts more like a noise at this point.

  3. readability-identifier-length - eventuals use one-letter-variables extensively across the codebase, no need for this check today.

aviator-app[bot] commented 1 year ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue-ready label.