search

3scale-ops / prometheus-exporter-operator

Operator to centralize the setup of 3rd party prometheus exporters on Kubernetes/OpenShift, with a collection of grafana dashboards
Apache License 2.0
43 stars 15 forks source link

Feat/Remove deprecated name field from grafana dashboard template #35

Closed slopezz closed 2 years ago

slopezz commented 2 years ago

Related to https://github.com/3scale/platform/issues/996

With grafana-operator v4.X, the optional GrafanaDashboard spec.name field has been removed from CRD, so it needs to be removed from the tamplete.

There was no issue, this value was not being used for anything, actually was optional, so although the field was deleted from GrafanaDashboard CRD, prometheus-exporter-operator was not failing to reconcile PrometheusExporter CRs

/kind bug /priority important-soon /assign

3scale-robot commented 2 years ago

LGTM label has been added.

Git tree hash: bfadb1b4351f20d115855929c6f7b4df7fed1d06

slopezz commented 2 years ago

/approve

3scale-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/prometheus-exporter-operator/blob/main/OWNERS)~~ [slopezz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment