Feat/Update prometheus-exporter-operator to manage possible different GrafanaDashboard apiVersions

[slopezz]

On https://github.com/3scale-ops/prometheus-exporter-operator/issues/48 it was reported a bug which made the operator to fail on the management of the GrafanaDashboard custom resource, due to using an old API.

It seems there is an API change on grafana-operator v5.0.0 from June 2023 https://github.com/grafana-operator/grafana-operator/releases/tag/v5.0.0

According to the migration docs https://github.com/grafana-operator/grafana-operator/blob/master/docs/blog/v4-v5-migration.md, it affects to prometheus-exporter-operator on 2 places:

• API Version
  • v4:integreatly.org/v1alpha1
  • v5: grafana.integreatly.org/v1beta1)
• Label selector, so the grafana instance know which dashboards will reconcile
  • v4. it was used the usual metadata.labelX
  • v5: it uses a new field on the spec, spec.instanceSelector.matchLabels.labelX

So the operator has been adapted to have the 2 possible GrafanaDashboard apiVersions, since there is a breaking change at grafana-operator level, and it is really possible that not everybody have updated yet to newer grafana-operator v5.0.0:

• Added new grafanaDashboard.apiVersion CRD field with the 2 possible apiVersions
• Adapted the ansible role (defaults, tasks, template) to manage a GrafanaDashboard with the 2 different apiversion/ labelSelector depending on the value of grafanaDashboard.apiVersion (if defined in the CR), or using the default value (if not defined in the CR)
• Default value for grafanaDashboard.apiVersion will be the old apiVersion=v1alpha1, the one used by most people at the moment
  • If you update the grafana-operator to v5.0.0, you will need to use in the CR spec.grafanaDashboard.apiVersion = v1beta1
  • In future releases, the default value will be updated to use the new apiVersion apiVersion=v1beta1
  • A new e2e test has been added to test the possible modification of the spec.grafanaDashboard.apiVersion

/kind bug /kind feature /priority important-soon /assign

[3scale-robot]

LGTM label has been added.

Git tree hash: 78c8cc12e94b6ff462a09f49afc5f88f8b3c7f4d

[slopezz]

/approve

[3scale-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/prometheus-exporter-operator/blob/main/OWNERS)~~ [slopezz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment