42-AI / Elegant-Elegans

MIT License

3 stars 0 forks source link

34 converter full merge #41

Closed shell02 closed 2 years ago

shell02 commented 2 years ago

Description

Merging of the three parts convert module into one. Added a usage section in the readme.md

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have added the needed labels
[ ] I have linked this PR to an issue
[x] I have linked this PR to a milestone
[x] I have linked this PR to a project
[x] I have tested this code
[x] I have added / updated tests (unit / functionals / end-to-end / ...)
[x] I have updated the README and other relevant documents (guides...)
[x] I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Some changes are still required :

Clarification of the extension needed (.tiff or .tif) and of the files needed (.json or metadata.txt)

rcatini commented 2 years ago

The extension of the tiffs files has been switched to .tif (with only one f), because the test file names are formatted in this way The tests of the json_parser are still an hybrid (some are using fixtures, some others not #18 ). On my computer a video is correctly built from the test1 folder (s3://lab-nematode/tests/test_1), in both of the supported formats (mp4 and avi). The checker is not looking at metadata.json anymore, because in reality we are parsing and validating metadata.txt. The checker and the associated tests have been accordingly switched to metadata.txt.

madvid commented 2 years ago

I'm currently fixing the code. This PR must not be merge in the meanwhile