Closed COTHSC closed 2 years ago
First of all, there is a really big problem.
We should never have 1552 files changed in in a PR.
the hidden file gitmodules has not been modified/removed
Sample02
?Xerces-J-bin.2.12.2
? It is too big / to many files in it. Instead describe how to get it and why do we need it ?__MACOSX
data
? Is it related to the associated issue of the PR ?octave_measures_backup
? Is it related to the associated issue of the PR ?octave-workspace
? why is it here ? is it related to the issue ?What is Sample02
?
Its a small sample that can be used to run CeleST, I removed it now that the information on where to get sample data is in the howto
What is Xerces-J-bin.2.12.2
? It is too big / to many files in it. Instead describe how to get it and why do we need it ?
Its a java library needed to read and write to xml files, if I remove it, the user will need to change the path in the CeleST file, I will document this in the setup.md file
I removed __MACOSX
oops, my bad!
what is data
? Is it related to the associated issue of the PR ?
Its the directory where CeleST outputs, if it doesn't exist, it will be created by CeleST, I think it makes sense for it to stay so measures made by anyone can be loaded and visualized by others
what is octave_measures_backup
? Is it related to the associated issue of the PR ?
Yes, We will need it to compare to other measures, made in matlab etc.
What is octave-workspace
? why is it here ? is it related to the issue ?
I had misunderstood its usefullness, it was generated during a crash and has been removed
Tests are failing due to WF NTP source code which does not comply with our code standard
Description
Replaced wfntp submodule, wfntp is now part of our codebase, added how to's for celeST and WF_NTP