Upgrade the React and Material-UI version

4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.

https://gdevelop.io

Other

11.64k stars 886 forks source link

Open khushbooag4 opened 1 year ago

khushbooag4 commented 1 year ago

Upgrade React.js and Material-UI to their latest version for better performance across the whole app.

Goals:

This will help to ensure that the user interface of the GDevelop project is consistent that it runs smoothly and efficiently and remain up-to-date with the latest versions.
Benefit from latest updates of Material UI regarding user interactions with the components

Any suggestions ?? @4ian @ClementPasteau

AlexandreSi commented 1 year ago

Here are some challenges I see for this task:

Adapt API of V4 Lab components that were integrated into the core library of V5 (Skeleton, Autocomplete, Treeview, etc.)
- With a particular focus on TreeView for the VariablesList component.
Make sure the functions in the file https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/UI/MaterialUISpecificUtil.js still work.
Make sure that the class names we have used when styling are still relevant:
- with makeStyles method
- when creating the themes in https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/UI/Theme/CreateTheme.js
More generally, spot the edge cases that might have been introduced using unusual props of V4 components

The storybook will be of great help

khushbooag4 commented 1 year ago

Tasks to perform

[ ] I have to upgrade the material UI version from v4 to v5.
[ ] I have to check if the file https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/UI/MaterialUISpecificUtil.js is working or not with the v5 version of MUI.
[ ] I have to spot all the changes that may occur while upgrading MUI v4 to v5.

To Check

[ ] Is the current version compatible with React & TypeScript with MUI v5 as
In MUI V5, the minimum supported version of React has been increased from v16.8.0 to v17.0.0 and the minimum supported version of TypeScript has been increased from v3.2 to v3.5.
As I can refer to this Doc they are breaking changes

@4ian @AlexandreSi @ClementPasteau

AlexandreSi commented 1 year ago

We are not using Typescript but Flow in the repository, I'll let you see the changes between those 2 solutions.

khushbooag4 commented 1 year ago

okay @AlexandreSi