4pr0n / ripme

Downloads albums in bulk
MIT License
916 stars 203 forks source link

ImgurRipper title grabbing sometimes sliently fails #587

Closed cyian-1756 closed 7 years ago

cyian-1756 commented 7 years ago

Expected Behavior

Ripme gets the album title from the imgur page

Actual Behavior

Ripme gets the string "Imgur: The most awesome images on the Internet" as the title

cyian-1756 commented 7 years ago

Looking over the source of http://imgur.com/a/9rX1v [NSFW] having the ripping fall back to the tag if og:title returns "Imgur: The most awesome images on the Internet" might fix it</p> <p>Edit: Falling back to the <title> tag doesn't fix it. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/metaprime"><img src="https://avatars.githubusercontent.com/u/7526632?v=4" />metaprime</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>Duplicate of #509</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/metaprime"><img src="https://avatars.githubusercontent.com/u/7526632?v=4" />metaprime</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Edit: Falling back to the <title> tag doesn't fix it.</p> </blockquote> <p>Right, because the problem is the album doesn't have a title and the actual title of the page is the one imgur provides when there is no album title. We can detect this text and know from there that the album title should be left blank.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/cyian-1756"><img src="https://avatars.githubusercontent.com/u/17493676?v=4" />cyian-1756</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Right, because the problem is the album doesn't have a title and the actual title of the page is the one imgur provides when there is no album title</p> </blockquote> <p>Nope, I'm talking about when this happens with albums that are titled when imgur is under high load. Even tho the album has a title imgur doesn't display the title on the page</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/metaprime"><img src="https://avatars.githubusercontent.com/u/7526632?v=4" />metaprime</a> commented <strong> 7 years ago</strong> </div> <div class="markdown-body"> <p>I've never seen that happen, but definitely something to take into account. Thanks for being thorough!</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>