Added a "Shopping List" mode feature

[williammetcalf]

• Added a "Shopping List" mode, where you can specify items that you want and the scan will inform you of everything you are missing. It also adds a dynamically added "Trash" recipe that identifies items in your inventory that you don't need to accomplish your goal

  • If it isn't clear in the screenshots, the recipe list is filtered to only show the recipes that are in the chain for the specified shopping list
  • The recipe list also includes the "trash" recipe, which selects up to 4 items that aren't in the shopping list tree

• I also just refactored the initial code base to break it out into multiple files, which I think is just easier to maintain

  • The first two commits are 100% the refactor, all commits beyond that are my feature changes

• Fixed misspelled Treant Horder > Treant Horde

• I noticed the settings.ini file wasn't commited to the repo, so I added it to the .gitignore

[4rtzel]

That's a lot of work! Einhar approves

I'll try to review it as soon as possible. Trying to catch up with real life stuff after providing support for this tool for last 5 days 8 hours a day.

[meepen]

Haha, both of us did th same two small things with settings and rename treant :)

[JustLKS]

Omg thats amazing! where can I doiwnload it williammetcalf?

[4rtzel]

Testing the changes. Some feedback so far:

Running scan without shopping list causes an exception:

...\src\RecipeShopper.py", line 26, in get_missing_items
    complex_missing_items = list(item for item in missing_items if len(self._item_map.get_subtree_for(item).components) > 0)
RuntimeError: generator raised StopIteration

The button in the settings to set shopping list is misnamed (Set scan/hide hotkey).

Trying to clear the shopping list raises an exception here (line 459):

    def _update_shopping_list(self) -> None:
        # TODO: validate it
        shopping_list = list(map(lambda x: x.strip(), self._shopping_list_entry.get().split(",")))
        for item in shopping_list:
            if item not in self._items_map.items():
                print("Unknown Recipe:", item)
>>              raise ValueError

[williammetcalf]

@4rtzel alright I added some error handling. TBH I haven't written python in like 7 years I think, and I'm definitely no expert with using TKinter, so idk if I did this especially well. I'm definitely open to suggestions on how to handle errors for this type of thing.

I'm also sure it would be a bit confusing to a new user to understand exactly what to put in for the recipes, since its case/hypen sensitive

[williammetcalf]

Omg thats amazing! where can I doiwnload it williammetcalf?

For the time being you would need to clone my fork of this repository and setup/run the python code directly, I don't feel comfortable personally packaging and distributing someone else's hard work. One this PR gets merged the project will need to be re-released

[4rtzel]

@4rtzel alright I added some error handling. TBH I haven't written python in like 7 years I think, and I'm definitely no expert with using TKinter, so idk if I did this especially well. I'm definitely open to suggestions on how to handle errors for this type of thing.

I'm also sure it would be a bit confusing to a new user to understand exactly what to put in for the recipes, since its case/hypen sensitive

I'm not a Python developer either so I can't really tell how good/bad it is :). For me it seems "good enough". Especially giving that this tool is a temporary solution for the UI problems in PoE.

As long as the main feature of your changes is functional, I'll merge them. You can leave the polishing to me.

[williammetcalf]

I've been using it myself for a few days and it does seem to work. There's a few more additions I'd like to make but cant be bothered until I see what changes GGG makes.

Ideally I'd like it to show on-screen the items you are missing to make it easier to keep an eye out for them, and it would be nice if it filtered the recipes shown even smarter to not lead you to making duplicates of items you've already made. But I think this is a good baseline for the concept

[4rtzel]

I agree with you about waiting for the solution that GGG will come up with, before doing any more changes. My current plan is to merge your work and release v0.2.0 with keyboard changes.

After that, I'll merge https://github.com/4rtzel/poe-archnemesis-scanner/pull/35 for v0.2.1 release (@meepen changes modify the algorithm quite significantly, so it would be nice if people had a version to fallback to in case of any issues).

[4rtzel]

Played a little bit with the changes. Besides the issues, that I mentioned above (already fixed), everything seems to be working fine.

The code also looks much better now with the split. There are a few stylistic issues but nothing critical. Merging.